Skip to content

Avoid panics when compiling for custom boards #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2019
Merged

Avoid panics when compiling for custom boards #491

merged 1 commit into from
Nov 28, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Nov 20, 2019

Fixes #177

When working with custom boards some corner cases might arise and provide an inconsistent in-memory representation of the cores. This PR introduces more checks for structs and fields that might be nil at some point during compilation.

@masci masci added this to the 0.7.0 milestone Nov 20, 2019
rsora
rsora approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast LGTM

@masci masci merged commit da8fc05 into master Nov 28, 2019
@masci masci deleted the massi/177 branch November 28, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

SIGSEGV when compiling for custom boards
2 participants
@masci @rsora